-
Notifications
You must be signed in to change notification settings - Fork 405
feat: govdao v3 better rendering #4164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Must not contain the "don't merge" label Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
urequire.Equal(t, true, contains(dao.Render(""), "NO PERCENT: 68.42105263157895%")) | ||
} | ||
|
||
func TestProposalPagination(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to test this, its tested in p/demo/avl/pager
already
|
||
func contains(s, substr string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also strings.Contains
exists
r.HandleFunc("/", func(rw *mux.ResponseWriter, req *mux.Request) { | ||
rw.Write(ren.renderActiveProposals(req.RawPath, d)) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this checks for pkgpath:/
so kind of useless as well
out += ufmt.Sprintf("[Detailed voting list](%v:%v/votes)", ren.relativeRealmPath, sPid) | ||
out += "\n\n---\n\n" | ||
|
||
out += renderActionBar(sPid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not missing the eligible tiers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's given out by out += ps.String()
Let's wait until we're good with the current impl on the chain and then we can easily upgrade to this. |
Description
Adds better rendering to GovDAO v3. Includes nicer proposal listing, proposal page, and txlinks to vote on proposals.

